ux(frontend/recs): enlarge cell-expand chevron + reposition (closes #280) - #798
Conversation
Bump .rec-cell-chevron from font-size 1.2em/24px target to 1.5em/32px, add focus-visible highlight, and add two tests: one asserting the chevron is a <button> outside .rec-cell-summary-content (keyboard accessible without extra keydown wiring), one confirming no-overlap with the summary content cell.
|
Warning Review limit reached
More reviews will be available in 9 minutes and 9 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR improves the recommendation cell chevron control by adding DOM validation for its accessibility structure and enhancing its visual presentation. A new test asserts the chevron is a real button with aria-label and proper nesting, while CSS updates enlarge its interactive dimensions, add smooth transitions, and refine the hover/focus-visible styling to use primary color and info-background theming. ChangesRecommendation cell chevron control
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Actionable comments posted: 0 |
|
@coderabbitai full review |
Rate Limit Exceeded
|
|
@coderabbitai review |
Rate Limit Exceeded
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
.rec-cell-chevronfont-size from1.2emto1.5emand minimum click target from24pxto32pxso the glyph is a comfortable 32x32 tap/click targetpadding: 6px,border-radius: 4px, and afocus-visiblehighlight (background: var(--cudly-info-bg)) so keyboard focus is visible without extra keydown handlers (native<button>handles Enter/Space)<button type="button">witharia-labeland lives outside.rec-cell-summary-content; (2) existing placement test continues to confirm it sits intd.checkbox-colBefore / after CSS
font-size1.2em1.5empadding4px6pxmin-width/height24px32px:hoverselector.rec-cell-chevron:hover.rec-cell-chevron:hover, .rec-cell-chevron:focus-visibleTest plan
npx tsc --noEmitcleanjest src/__tests__/recommendations*.test.ts-- 320 passed, 0 regressions<button>outside.rec-cell-summary-contenttd.checkbox-colaria-expandedSummary by CodeRabbit