fix(inventory): default sub-tab is Active Commitments, not RI Exchange by cristim · Pull Request #757 · LeanerCloud/CUDly

cristim · 2026-05-27T12:05:42Z

Summary

Clicking "Inventory & Coverage" in the sidebar opened the RI Exchange sub-tab by default. Users expect the at-a-glance Active Commitments view; RI Exchange is a more specialised workflow.

Fix

DEFAULT_SUB_SECTION changed from 'ri-exchange' to 'active-commitments'.
index.html: active class and aria-selected="true" moved from RI Exchange to Active Commitments; hidden flipped accordingly.
Deep links (?subSection=ri-exchange) still work; only the no-param default changes.

Files changed

frontend/src/inventory.ts
frontend/src/index.html
frontend/src/__tests__/inventory.test.ts

Test plan

Updated buildInventoryDOM helper, fallback test (unknown sub-section -> active-commitments), and loadInventory first-load assertion.
All 63 test suites pass (2018 tests).
Manual: click Inventory & Coverage from a fresh page load, confirm Active Commitments is visible and highlighted.

Closes #751.

Summary by CodeRabbit

Updates
- The Inventory & Coverage tab now defaults to displaying the "Active Commitments" sub-tab instead of "RI Exchange" when you first access the section.

coderabbitai · 2026-05-27T12:05:53Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e9f0730-1772-4488-9377-30e49e017053

📥 Commits

Reviewing files that changed from the base of the PR and between 3249775 and 13b99dd.

📒 Files selected for processing (3)

frontend/src/__tests__/inventory.test.ts
frontend/src/index.html
frontend/src/inventory.ts

📝 Walkthrough

Walkthrough

The default Inventory & Coverage sub-section was switched from RI Exchange to Active Commitments. The constant definition, HTML markup (including active state and visibility), and test expectations were updated consistently to reflect the new landing tab behavior.

Changes

Default Inventory Sub-Section

Layer / File(s)	Summary
Default sub-section constant and documentation `frontend/src/inventory.ts`	`DEFAULT_SUB_SECTION` is changed from `ri-exchange` to `active-commitments`, and `loadInventory()` documentation is updated to reflect the new default behavior when no sub-section is selected in the session.
DOM markup for new default state `frontend/src/index.html`	"Active commitments" button is marked as active/selected and its panel is made visible by default; "RI Exchange" button loses its active state and its panel is explicitly hidden.
Test updates for new default behavior `frontend/src/__tests__/inventory.test.ts`	Test fixtures and DOM builder now set `active-commitments` as the active tab with `ri-exchange` inactive; assertions updated so unknown sub-sections fall back to `active-commitments` and default landing checks verify that tab is shown.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

LeanerCloud/CUDly#760: Both PRs modify the Inventory & Coverage sub-tab behavior in frontend/src/inventory.ts/inventory.test.ts (default/fallback subsection selection vs coverage sub-tab routing/loader), so the main PR's UI tab switching changes are directly connected to the coverage tab implementation work.

Poem

🐰 Hops and commits with glee,
Active wins by default, you see!
RI sleeps in hidden night,
While commitments shine bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: switching the default inventory sub-tab from RI Exchange to Active Commitments.
Linked Issues check	✅ Passed	All acceptance criteria from issue `#751` are met: defaulting to Active Commitments [`#751`], preserving deep-link behavior [`#751`], and updating UI tab order [`#751`].
Out of Scope Changes check	✅ Passed	All changes directly address the stated objective of changing the default inventory sub-tab with no unrelated modifications present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/751-inventory-default-tab

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cristim · 2026-05-27T12:07:57Z

@coderabbitai review

coderabbitai · 2026-05-27T12:08:02Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-27T16:44:55Z

@coderabbitai review

coderabbitai · 2026-05-27T16:45:02Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-27T18:19:44Z

@coderabbitai full review

coderabbitai · 2026-05-27T18:19:50Z

✅ Actions performed

Full review triggered.

Users opening Inventory & Coverage expect the at-a-glance commitment view, not the more specialised RI Exchange workflow. Closes #751.

cristim · 2026-05-27T19:02:22Z

@coderabbitai review

coderabbitai · 2026-05-27T19:02:28Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…min (closes #902) (#905) Resolve QA A.4: Inventory & Coverage remembered its last sub-tab via hidden in-memory session state while Admin always read its sub-tab from the /admin/<subtab> URL. The inconsistency was the defect. Make Inventory sub-tabs URL-addressable as /inventory/<subtab>, matching the existing Admin convention: - loadInventory() now derives the sub-section from the URL path (getInventorySubTabFromPath), not the module-level currentSubSection, so a fresh /inventory lands on the default (active-commitments) and a /inventory/<subtab> deep link lands on that sub-tab. - A sub-nav click routes through navigation.switchInventorySubTab, which pushes /inventory/<subtab> via history.pushState so the view is shareable/bookmarkable and browser back/forward works. - The history push lives in navigation.ts alongside switchSettingsSubTab so the single historyId counter stays authoritative for the back/forward dirty-guard; inventory.ts keeps the pure DOM view switch. Supersedes the partial PR #757 session-memory behavior with explicit URL state. Both pages now behave identically; existing /admin/* deep links are unaffected. Tests assert, for each page: no param -> default sub-tab, explicit param -> that sub-tab, switching updates the URL (query/hash preserved, no duplicate entry), and unknown param -> default.

cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/this-sprint Within the current sprint impact/all-users Affects every user effort/xs Trivial / one-liner type/bug Defect labels May 27, 2026

fix(inventory): default sub-tab is Active Commitments, not RI Exchange

13b99dd

Users opening Inventory & Coverage expect the at-a-glance commitment view, not the more specialised RI Exchange workflow. Closes #751.

cristim force-pushed the fix/751-inventory-default-tab branch from efcd122 to 13b99dd Compare May 27, 2026 19:02

cristim merged commit eda0c6b into feat/multicloud-web-frontend May 27, 2026
5 checks passed

cristim mentioned this pull request May 28, 2026

Inventory & Coverage opens RI Exchange by default; should default to Active Commitments #751

Closed

coderabbitai Bot mentioned this pull request Jun 1, 2026

fix(inventory): Active Commitments + Coverage honor Main Header chips #881

Merged

3 tasks

This was referenced Jun 1, 2026

ux: make Inventory + Admin sub-tabs URL-addressable with default-first (QA A.4) #902

Closed

feat(ux): URL-addressable sub-tabs (default-first) for Inventory + Admin (QA A.4) #905

Merged

cristim deleted the fix/751-inventory-default-tab branch June 3, 2026 21:54

Uh oh!

Conversation

cristim commented May 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fix

Files changed

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

cristim commented May 27, 2026

Uh oh!

coderabbitai Bot commented May 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cristim commented May 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading