fix(iac/aws-lambda): preserve Function URL via moved block (followup to #574)

[cristim]

Summary

Adds a moved block to preserve aws_lambda_function_url.main across the count removal from #574.

Why this is urgent

PR #574 merged commit 601318f49 removed count = var.enable_function_url ? 1 : 0 from aws_lambda_function_url.main. The terraform address changed from aws_lambda_function_url.main[0] to bare aws_lambda_function_url.main. Existing state still holds the resource at [0]. Without a moved block, the NEXT terraform apply would:

• DESTROY the existing Function URL (current dev: https://33pz7pombdqwu3bdlxp4lqxyra0bsriy.lambda-url.us-east-1.on.aws)
• CREATE a new Function URL with a brand-new random host

Cascading break:

• lambda_allowed_origins in github-dev.tfvars pins the old host -> CORS rejects the new URL until tfvars is updated AND re-applied
• DASHBOARD_URL env var pins the old host -> invite/reset emails carry dead links
• Frontend bundles that bake the URL point to nothing
• Any external integration on the URL host breaks

Fix

One-line moved block in terraform/modules/compute/aws/lambda/main.tf:

moved {
  from = aws_lambda_function_url.main[0]
  to   = aws_lambda_function_url.main
}

Terraform treats this as a state-index update, NOT a destroy/create. URL host preserved across apply.

Test plan

• terraform validate clean on both module + env layer
• terraform fmt clean
• No semantic change to deployed resources; ONLY a state-address rename

Land BEFORE next deploy

Once this merges, the next terraform apply is safe. If a deploy happens between #574 merging and this PR landing, the dashboard breaks. Worth fast-tracking.

[coderabbitai]

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 13 minutes and 44 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49cb9c5e-e3ec-43be-93b5-dbcbec2ef886

📥 Commits

Reviewing files that changed from the base of the PR and between f65998a and 2fb3dc0.

📒 Files selected for processing (1)

• terraform/modules/compute/aws/lambda/main.tf

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/lambda-function-url-moved-block

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.