Skip to content

test(azure/savings-plans): cover unsupported payment option in GetOfferingDetails - #673

Merged
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
fix/issue-592-bad-payment-option-test
May 22, 2026
Merged

test(azure/savings-plans): cover unsupported payment option in GetOfferingDetails#673
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
fix/issue-592-bad-payment-option-test

Conversation

@cristim

@cristim cristim commented May 22, 2026

Copy link
Copy Markdown
Member

Adds the regression test CodeRabbit requested on PR #592 (already merged). #592 fixed the payment-option switch to return an error on an unrecognized option rather than silently falling back to no-upfront, but the guarding test was missing. This adds TestGetOfferingDetails_BadPaymentOption asserting an unsupported option (Quarterly) returns an 'unsupported payment option' error and does not fall back. savingsplans suite 35/35 green.

TestGetOfferingDetails_BadPaymentOption asserts that an unknown payment
option ("Quarterly") returns an error containing "unsupported payment
option" and does not silently fall back to no-upfront. Addresses the
CodeRabbit finding from PR #592.
@cristim cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline impact/internal Team-internal only effort/xs Trivial / one-liner type/chore Maintenance / non-user-visible labels May 22, 2026
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@cristim has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 22 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2772253c-3015-4fef-82a0-443c8cf9d5d7

📥 Commits

Reviewing files that changed from the base of the PR and between 6fa5048 and db6b5d8.

📒 Files selected for processing (1)
  • providers/azure/services/savingsplans/client_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-592-bad-payment-option-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@cristim

cristim commented May 22, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
cristim merged commit cb413e5 into feat/multicloud-web-frontend May 22, 2026
4 checks passed
@cristim
cristim deleted the fix/issue-592-bad-payment-option-test branch May 22, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant