test(purchase): stub RecoverStrandedApprovals late-completion mock to fix panic

[cristim]

Closes #657. Stubs the GetExecutionByID call in the RecoverStrandedApprovals race-disambiguation path so the late-completion-not-clobbered test no longer panics on an unstubbed mock. Full internal/purchase suite green with -race (144 pass).

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for purchase execution recovery scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 971a08ee-9747-4816-bbee-9f466bdc9db4

📥 Commits

Reviewing files that changed from the base of the PR and between e09d0a7 and fa76556.

📒 Files selected for processing (1)

• internal/purchase/manager_test.go

---

📝 Walkthrough

Walkthrough

This PR fixes a test panic in TestManager_RecoverStrandedApprovals_LateCompletionNotClobbered by adding a missing mock stub. The test now stubs GetExecutionByID to return a completed execution, allowing the recovery path to verify it correctly skips already-completed executions when a status transition fails.

Changes

Recovery Race Detection Test

Layer / File(s)	Summary
Mock completion check in late-completion recovery test internal/purchase/manager_test.go	Mock expectation for GetExecutionByID(ctx, "exec-raced") returns an execution with Status: "completed", verifying the recovery sweep correctly interprets a failed status transition as a race condition by fetching the row state and skipping the execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• LeanerCloud/CUDly#657: Directly fixes the panic caused by the unstubbed GetExecutionByID call in the late-completion recovery path.
• LeanerCloud/CUDly#651: Addresses the same failing test and missing mock for GetExecutionByID in RecoverStrandedApprovals race detection.

Possibly related PRs

• LeanerCloud/CUDly#635: The main PR's GetExecutionByID stub addition directly refines the stranded-approval recovery race-handling behavior introduced by that PR's RecoverStrandedApprovals implementation.

Suggested labels

severity/low, bug

Poem

🐰 A test that panicked without a trace,
Now mocks the fetch that handles the race,
The sweep sees completion and skips with grace,
No clobbering here—just the right embrace! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the fix: stubbing a mock call (GetExecutionByID) in the RecoverStrandedApprovals test to resolve a panic.
Linked Issues check	✅ Passed	The PR directly addresses issue #657 by adding the missing GetExecutionByID mock stub, allowing the test to exercise the late-completion-not-clobbered path without panicking.
Out of Scope Changes check	✅ Passed	All changes are narrowly scoped to fixing the mock panic in the single test file without introducing unrelated modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/657-stranded-approvals-mock-panic

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.