Skip to content

docs(README): document per-account service overrides (closes #117) - #170

Merged
cristim merged 3 commits into
mainfrom
docs/issue-117-account-overrides
Jul 19, 2026
Merged

docs(README): document per-account service overrides (closes #117)#170
cristim merged 3 commits into
mainfrom
docs/issue-117-account-overrides

Conversation

@cristim

@cristim cristim commented Apr 28, 2026

Copy link
Copy Markdown
Member

Summary

Closes #117.

Per-account service overrides have been a feature since migration 000011_cloud_accounts.up.sql (mid-2024) and now have full UI coverage thanks to #72 (inline payment edit) and #106 (create modal). None of it was documented, so users landing on the dashboard saw the panel + the Add modal with no narrative for what overrides ARE, when to use them, or how they interact with the global defaults.

What's added

A new "Per-Account Service Overrides" section between "Coverage Percentage" and "Safety Features" covering:

.markdownlint.yaml

Disables MD060 (table-column-style) — same rationale as PR #169. Landing here too in case the PRs merge in a different order; both diffs are idempotent.

🤖 Generated with claude-flow

Summary by CodeRabbit

  • Documentation
    • Added guidance on using per-account service overrides to customize purchasing defaults (term, payment, coverage, enabled status) beyond global settings
    • Documented web UI workflows for creating, editing, and resetting overrides
    • Clarified "Inherit" behavior for blank fields and API endpoint usage

Review Change Stack

@cristim

cristim commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7bea76d6-7aea-45c9-8741-cc82b5c7d4b9

📥 Commits

Reviewing files that changed from the base of the PR and between abb5d35 and cc91cad.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

README.md now documents per-account service overrides—a feature allowing accounts to override global purchasing defaults (term, payment, coverage, enabled) for specific provider-service pairs. The section covers UI workflows, blank-field inheritance, an AWS-only V1 boundary, and the underlying API endpoint used by both UI and scripted setups.

Changes

Per-Account Service Overrides Documentation

Layer / File(s) Summary
Per-Account Service Overrides documentation section
README.md
New section explaining the concept of per-account service overrides, when to use them, UI-based creation/editing/reset workflows, inheritance semantics for blank fields (sparse PUT), AWS-only V1 limitation, and the API endpoint (PUT /api/accounts/:id/service-overrides/...) used by both UI and scripted setups.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tale of overrides so fine,
Per account, per service—a design!
Global defaults bow to local will,
Blank fields inherit, blanks sit still.
AWS leads the V1 way,
Documented bright for users' day! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: documenting per-account service overrides in the README, with a reference to the closed issue #117.
Linked Issues check ✅ Passed The PR comprehensively addresses all coding-related requirements from issue #117: documents concept, use cases, UI navigation, edit methods, 'Inherit' semantics, API parity, and migration compatibility.
Out of Scope Changes check ✅ Passed All changes are in scope: README documentation for the override feature, and a related .markdownlint.yaml update to disable MD060 matching the upstream configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/issue-117-account-overrides

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline impact/internal Team-internal only effort/xs Trivial / one-liner type/docs Documentation labels Apr 28, 2026
@cristim
cristim force-pushed the docs/issue-117-account-overrides branch from c2c7a5e to abb5d35 Compare April 29, 2026 22:46
@cristim

cristim commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

Rebased onto current feat/multicloud-web-frontend (was c2c7a5e, now abb5d35). Conflict was in .markdownlint.yaml only — README.md merged cleanly. Same conflict pattern as PR #169: upstream PR #105 pinned MD060: leading_and_trailing; this PR's commit additionally disabled MD060. Resolved by keeping upstream's pin and dropping the PR's MD060 change — the commit message already noted both diffs are idempotent across landing order. Verified markdownlint README.md is clean against upstream's pin. @coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

@cristim Sure! Triggering a review of the rebased changes now.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented May 19, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

@cristim

cristim commented May 22, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented May 22, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented May 25, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented May 27, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented May 27, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

@cristim

cristim commented May 27, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

@cristim

cristim commented May 28, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

@cristim

cristim commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Rate Limit Exceeded

@cristim have exceeded the limit for the number of chat messages per hour. Please wait 37 minutes and 7 seconds before sending another message.

@cristim

cristim commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@cristim
cristim changed the base branch from feat/multicloud-web-frontend to main June 9, 2026 15:49
@cristim
cristim force-pushed the docs/issue-117-account-overrides branch from a95c724 to e235425 Compare June 19, 2026 15:34
@cristim

cristim commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim

cristim commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
cristim force-pushed the docs/issue-117-account-overrides branch from e235425 to 5022489 Compare July 10, 2026 14:30
@cristim

cristim commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim and others added 3 commits July 17, 2026 21:31
Closes #117.

Per-account service overrides have been a feature since migration
000011_cloud_accounts.up.sql (mid-2024) and now have full UI coverage
via #72 (inline payment edit) and #106 (create modal). Adds a new
"Per-Account Service Overrides" section to README between "Coverage
Percentage" and "Safety Features" covering:

- Concept + when to use vs the global Settings → Purchasing card.
- Web-UI walkthrough (Settings → Accounts → expand → Service overrides).
- AWS-only V1 boundary callout pointing at #109 for Azure/GCP.
- How to edit existing overrides — inline Payment per #72, Reset, and
  the #110 follow-up for inline Term/Coverage/Enabled.
- "Inherit" semantics: blank fields are not stored as a sentinel; the
  PUT request stays sparse and the engine reads the global default at
  evaluation time.
- API parity note: the override modal targets the same endpoint as
  scripted setups; both write the same row.

Also disables MD060 (table-column-style) in .markdownlint.yaml — same
rationale as PR #169 (landing here too in case the PRs merge in a
different order; both diffs are idempotent).
…I (refs #117)

- Replace stale "#110 tracked / delete-and-recreate" limitation with the
  shipped reality: AWS overrides support inline edit of Term, Payment,
  Coverage, and Enabled directly on the row; non-AWS providers are read-only.
- Rename "Reset" to "Delete" throughout the override-editing section to match
  the current button label and confirm dialog title (per #114).
…ide section

- Replace the stale "AWS-only V1 boundary" callout with accurate text:
  the override modal is provider-aware and lists services for the
  account's provider (AWS, Azure, GCP). Issues #109 and #110 shipped
  and both the create modal and inline-edit work for all providers.
- Replace "Non-AWS overrides display field values as read-only text"
  with the correct statement that all override rows support inline edit
  (Term, Payment, Coverage, Enabled). References to tracking issue #109
  removed as it is closed.
- Replace five U+2014 em-dashes in the new section with punctuation
  that matches the project prose style (semicolons, parentheses, period).
@cristim
cristim force-pushed the docs/issue-117-account-overrides branch from 5022489 to cc91cad Compare July 17, 2026 18:32
@cristim
cristim merged commit 44427ba into main Jul 19, 2026
19 checks passed
@cristim
cristim deleted the docs/issue-117-account-overrides branch July 27, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/docs Documentation urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(README): document per-account service overrides

1 participant