refactor(aws): share resolveTag helper across service clients (closes #1390) - #1391
Conversation
|
@coderabbitai review |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
…1390) Move the 4-way duplicate resolveTag into purchasecfg.ResolveTag -- all four service packages (elasticache, memorydb, opensearch, redshift) already import purchasecfg so no new import is required. No behavior change; existing tests unchanged and green.
6fc7195 to
bfd11c9
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Merged to main (closes #1390): the 4 identical resolveTag copies #1389 added (one per service package) are consolidated into a single purchasecfg.ResolveTag - all 4 services already imported purchasecfg, so zero new imports. Behavior identical, tests unchanged. Owner-flagged during the merge-driver; the broader term-parser duplication the follow-up audit found is tracked in #1392. |
Summary
resolveTagthat refactor(aws): reduce 4 offering-match funcs below gocyclo 10 (closes #1388) #1389 introduced acrosselasticache,memorydb,opensearch, andredshiftservice clientspurchasecfg.ResolveTag(the one shared internal package all four already import), so no new import was neededpurchasecfg.ResolveTag(execID)No behavior change; all 218 existing tests pass unchanged.
Test plan
git grep -n "func resolveTag"shows only the shared copy inpurchasecfggo build ./...(providers/aws module) -- exit 0go vet ./...-- exit 0go test ./services/redshift/... ./services/opensearch/... ./services/memorydb/... ./services/elasticache/... ./internal/purchasecfg/...-- 218 passed, exit 0gocyclo -over 10 services/-- exit 0go build ./...-- exit 0