Skip to content

fix(frontend): resolve npm audit advisories keeping Security Scanning red - #1345

Merged
cristim merged 1 commit into
mainfrom
fix/frontend-npm-audit
Jul 3, 2026
Merged

fix(frontend): resolve npm audit advisories keeping Security Scanning red#1345
cristim merged 1 commit into
mainfrom
fix/frontend-npm-audit

Conversation

@cristim

@cristim cristim commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

All four are dev-only build/lint tooling. No --omit flags or audit-level loosening were added to CI. No config changes required: the webpack config uses CssMinimizerPlugin() with zero options (drop-in upgrade), and there is no ESLint config file in the frontend directory so the @typescript-eslint v6->v8 jump needs no rule changes.

Per-advisory notes

Advisory Package fixed Mechanism
GHSA-3ppc-4f35-3m26 + GHSA-7r86-cg39-jmmj + GHSA-23c5-xmqv-rm74 minimatch (transitive via @typescript-eslint/typescript-estree) Bumping @typescript-eslint to v8 pulls in a non-vulnerable minimatch
GHSA-5c6j-r48x-rmvq + GHSA-qj8w-gfj5-8c6v serialize-javascript (transitive via copy-webpack-plugin and css-minimizer-webpack-plugin) Bumping both plugins to their latest major pulls in serialize-javascript >=7.0.5
GHSA-hmw2-7cc7-3qxx (form-data), GHSA-2g4f-4pwh-qvx6 (ajv), GHSA-25h7-pfq9-p65f/GHSA-rf6f-7fwh-wjgh (flatted), GHSA-4x5r-pxfx-6jf8 (@babel/core), GHSA-f886-m6hf-6m8v (brace-expansion), GHSA-q3j6-qgpj-74h6/GHSA-v39h-62p7-jpjc (fast-uri), GHSA-3mfm-83xf-c92r+ (handlebars), GHSA-h67p-54hq-rp68 (js-yaml), GHSA-r5fr-rjxr-66jc+ (lodash), GHSA-3v7f-55p6-f55p/GHSA-c2c7-rcm5-vvqj (picomatch), GHSA-qx2v-qp2m-jg93 (postcss), GHSA-xpqw-6gx7-v673 (svgo), GHSA-8fgc-7cc6-rx7x/GHSA-38r7-794h-5758 (webpack), GHSA-58qx-3vcg-4xpx/GHSA-96hv-2xvq-fx4p (ws) All resolved by npm audit fix (semver-compatible updates)

Verification

npm audit --audit-level=high   -> found 0 vulnerabilities (exit 0)
npm run typecheck              -> exit 0
npm run build                  -> webpack 5.108.3 compiled (exit 0, perf warning pre-existing)
npm test                       -> 77 suites, 2553 passed, 1 skipped (exit 0)

Closes #1344

Bump four dev-tooling deps to clear all high/critical advisories caught by
`npm audit --audit-level=high` in the Security Scanning CI job:

- @typescript-eslint/{eslint-plugin,parser} ^6 -> ^8 (fixes GHSA-3ppc-4f35-3m26,
  GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74 via minimatch in typescript-estree)
- copy-webpack-plugin ^13 -> ^14 (fixes GHSA-5c6j-r48x-rmvq, GHSA-qj8w-gfj5-8c6v
  via serialize-javascript)
- css-minimizer-webpack-plugin ^5 -> ^8 (same serialize-javascript chain)

All four are dev-only build/lint tooling with low blast radius. Verified:
- npm audit --audit-level=high: 0 vulnerabilities (exit 0)
- npm run typecheck: exit 0
- npm run build: exit 0
- npm test: 77 suites, 2553 passed, 1 skipped (exit 0)
@cristim cristim added triaged Item has been triaged priority/p1 Next up; this sprint severity/high Significant harm urgency/this-sprint Within the current sprint impact/internal Team-internal only effort/s Hours type/security Security finding labels Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 29c978b0-f918-4c66-819e-d12702c1fa78

📥 Commits

Reviewing files that changed from the base of the PR and between 5f712a0 and d7fa9c7.

⛔ Files ignored due to path filters (1)
  • frontend/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • frontend/package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/frontend-npm-audit

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/internal Team-internal only priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/security Security finding urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(frontend): npm audit failures keep Security Scanning red after Go CVE fix

1 participant