style(frontend/recs): align cost-period selector inline with toolbar controls - #1118
Merged
Merged
Conversation
…controls The recommendations filter-status bar is flex/align-center, but the `.cost-period-selector-wrapper` span had no CSS, so the small "Show costs:" label aligned to the baseline of the taller base-styled select and appeared stacked above it. Make the wrapper an inline-flex (label + select vertically centered) and size the select to match the bar buttons, so the count, Expand all, "Show costs: <period>" and Columns all sit on one line.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Recommendations toolbar, the "Show costs:" label stacked above the period dropdown instead of sitting on the same line as the count / Expand all / Columns (see issue screenshot).
Cause
.recommendations-filter-statusis alreadydisplay:flex; align-items:center, but.cost-period-selector-wrapper(the span holding the label +<select>) had no CSS. The baseselectstyle (forms.css:padding:0.5rem; font-size:0.9rem) is taller than the bar's buttons, so the small label aligned to the select's baseline and rendered above it.Fix (CSS-only, scoped to the bar)
.cost-period-selector-wrapper→inline-flex; align-items:center; gapso the label + select are side-by-side, vertically centered..cost-period-select→ match the bar buttons'padding:0.25rem 0.6rem; font-size:0.85em.Now the count, Expand all, Show costs: and Columns all sit on one line, vertically centered.
CSS-only; no behavior change. The bundle is verified by the "Build frontend" CI check (local build skipped — fresh worktree without node_modules).