Severity: P3 (downgraded from P2 by the verifier). Confidence: high.
Affected files: Makefile.terraform:127-133, Makefile.terraform:141-143, scripts/tf-deploy.sh:33-35
Evidence: The targets pass -var="skip_docker_push=true" (etc.) as a 4th argument, but tf-deploy.sh consumes only $1..$3 and runs terraform apply -var-file="$PROFILE_FILE" with no $4/$@ passthrough; the -var flags are silently discarded.
Impact: make docker-skip performs a full deploy including the Docker build; make frontend-skip deploys the frontend anyway. The verifier found the targets were never functional regardless: none of the named variables is a declared root-module variable (a passed-through -var would hard-error), terraform's interactive approve gate intervenes before any mutation, and nothing references the targets. Worst case is wasted time, not data/money impact.
Recommendation: Forward extra args in tf-deploy.sh (shift 3; "$@") and plumb the variables, or delete the vestigial targets. Also note the if [ -z "$PROVIDER" ] usage check is unreachable under set -u.
Verifier verdict: downgraded to P3 - real dead tooling, but vestigial rather than a regression in a working operator path.
Source: docs/reviews/codebase-review-2026-06-10.md (automated multi-dimension code review, adversarially verified for P1/P2)
Severity: P3 (downgraded from P2 by the verifier). Confidence: high.
Affected files:
Makefile.terraform:127-133,Makefile.terraform:141-143,scripts/tf-deploy.sh:33-35Evidence: The targets pass
-var="skip_docker_push=true"(etc.) as a 4th argument, but tf-deploy.sh consumes only$1..$3and runsterraform apply -var-file="$PROFILE_FILE"with no$4/$@passthrough; the -var flags are silently discarded.Impact:
make docker-skipperforms a full deploy including the Docker build;make frontend-skipdeploys the frontend anyway. The verifier found the targets were never functional regardless: none of the named variables is a declared root-module variable (a passed-through -var would hard-error), terraform's interactive approve gate intervenes before any mutation, and nothing references the targets. Worst case is wasted time, not data/money impact.Recommendation: Forward extra args in tf-deploy.sh (
shift 3; "$@") and plumb the variables, or delete the vestigial targets. Also note theif [ -z "$PROVIDER" ]usage check is unreachable underset -u.Verifier verdict: downgraded to P3 - real dead tooling, but vestigial rather than a regression in a working operator path.
Source: docs/reviews/codebase-review-2026-06-10.md (automated multi-dimension code review, adversarially verified for P1/P2)