LibWeb: Fix Document::is_fully_active() and implement Badging API #7040
+126
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
badc08f to
0673156
Compare
When a navigable is being destroyed (e.g., via iframe.remove()), the has_been_destroyed flag is set immediately, but the navigable pointer is not nulled until later in a queued task. This causes is_fully_active() to incorrectly return true during the transitional period. Add a check for the has_been_destroyed flag to ensure the document is correctly detected as no longer fully active when its navigable is being destroyed.
Add support for the Badging API (https://w3c.github.io/badging/), which allows web applications to set application badges. This fixes the WPT test badging/non-fully-active.https.html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WPT test: badging/non-fully-active.https.html
Fixes Document::is_fully_active() to check the has_been_destroyed flag. When a navigable is destroyed, the flag is set immediately but the navigable pointer is cleared later in a queued task (see NavigableContainer::destroy_the_child_navigable), causing is_fully_active() to incorrectly return true during this gap.
Implements navigator.setAppBadge() and navigator.clearAppBadge() methods per the specification. Permission handling, badge display logic, and task queuing are not yet implemented.