LibWeb: Random WebGL improvements #6978
Open
+255
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use those everywhere else as those are more secure.
This implements setting and getting the value but it does nothing with it.
af8c31e to
f4da2e3
Compare
gmta
reviewed
Dec 9, 2025
| GC::Ptr<WebGLVertexArrayObject> m_current_vertex_array; | ||
| GC::Ptr<WebGLQuery> m_any_samples_passed; | ||
| GC::Ptr<WebGLQuery> m_any_samples_passed_conservative; | ||
| GC::Ptr<WebGLQuery> m_transform_feedback_primitives_written; |
Collaborator
There was a problem hiding this comment.
Shouldn't we visit these in visit_edges?
| // so it matches corresponding C++ class name, and does not require | ||
| // IDL generator to handle snake_case to TitleCase conversion. | ||
| // Having a different name is totally fine, because LegacyNoInterfaceObject | ||
| // prevents the name from being exposed to JavaScript. |
Collaborator
There was a problem hiding this comment.
Please reformat this comment to wrap at column 120. Also, should this be a FIXME for IDL generator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.