Conversation
… TestSchedulerProvider
…tor-android into example/ui-tests
…into example/ui-tests
harri35
approved these changes
Apr 24, 2024
Member
harri35
left a comment
There was a problem hiding this comment.
Added minor suggestions. UI tests get stuck if the device has a password manager like BitWarden installed, but dealing with this is not part of the scope of the task so let's ignore it here.
Looks good to me. Can be merged.
Awesome work!
| import mobi.lab.sample.app.common.test.Idler | ||
| import mobi.lab.sample.app.common.test.NoOpIdler | ||
| import javax.inject.Singleton | ||
|
|
Member
There was a problem hiding this comment.
Maybe just-in-case a comment here that this is the provider for UI test idler and this one provides the default no-op one and safe for production?
| @@ -0,0 +1,46 @@ | |||
| package mobi.lab.sample.app.common.test | |||
|
|
|||
| interface Idler { | |||
Member
There was a problem hiding this comment.
Maybe one-lin comment on how to use the Idler? Eg:
"Create and set busy before the works starts, mark as done when the job is done."
…into example/ui-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request gives a quick overview of changes needed to introduce UI/instrumentation testing capabilities.