Skip to content

Conversation

@LeviCameron1
Copy link
Collaborator

Rationale

Four fixes for the cageUI layout editor.

Related Pull Requests

Changes

  1. Clears transform on svgs when inserted into the DOM by dragging
  2. Remove empty space from the objects container making it cleaner and easier to use
  3. Clearing layout now properly clears all required states
  4. Use D3.pointer when dragging objects to prevent scaling issues on different sized rooms

@LeviCameron1 LeviCameron1 requested a review from dnicolalde June 12, 2025 17:22
Copy link
Collaborator

@dnicolalde dnicolalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we can keep the branch live until you solve the test problem.

@dnicolalde dnicolalde merged commit 6651dc5 into release24.11-SNAPSHOT Jun 12, 2025
9 of 11 checks passed
@dnicolalde dnicolalde deleted the 24.11_fb_cageUI_fix branch June 12, 2025 17:36
@dnicolalde dnicolalde restored the 24.11_fb_cageUI_fix branch June 12, 2025 17:36
@dnicolalde
Copy link
Collaborator

restore the branch, so you can continue submitted the changes to the teamcity test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants