Removing Unused Notifications #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ERROR: A pull request from |
dnicolalde
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the old perl notifications as well as the unused WNPRC EHR java notifications.
For the perl notifications, the automaticAlerts.cron was already updated so these no longer send, all I needed to do was remove the files.
For the WNPRC EHR java notifications, I deleted the file as well as the lines registering the notification in WNPRC_EHRModule.java and any triggers in TriggerScriptHelper.java.
The only remaining unused WNPRC EHR java notification is ColonyAlerts.java because there is a separate Behavior Notification that extends this file. I left it in for now, we can remove this later.