Use standard directories for client code#225
Merged
labkey-tchad merged 6 commits intorelease22.7-SNAPSHOTfrom Nov 7, 2022
Merged
Use standard directories for client code#225labkey-tchad merged 6 commits intorelease22.7-SNAPSHOTfrom
labkey-tchad merged 6 commits intorelease22.7-SNAPSHOTfrom
Conversation
Member
Author
|
@dnicolalde @csebranek If this looks good to you, I recommend applying the same change to your fork so that I can re-enable build caching on TeamCity and to |
… back webpack config, remove/fix test files
csebranek
approved these changes
Nov 7, 2022
Collaborator
csebranek
left a comment
There was a problem hiding this comment.
@labkey-tchad changes look good to me. I also moved a few more client side files over related to the water monitoring config. And restored water monitoring config that was unintentionally removed in this merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Using non-standard code locations interferes with Gradle's ability to build efficiently (by skipping unnecessary build steps and by caching build results).
Related Pull Requests
Changes
src/clientdirectory