Don't need to check for SearchService; it falls back to a no-op now#7035
Don't need to check for SearchService; it falls back to a no-op now#7035labkey-jeckels wants to merge 2 commits intodevelopfrom
Conversation
labkey-adam
left a comment
There was a problem hiding this comment.
Many files here have whitespace changes on every line; I doubt that's what you want. Same thing happened to me a week ago... I don't know why. I created a new FB with the same patch and it produced the expected diff. 🤷
Probably a line ending thing, possibly OSX vs Windows. Did you push your FB to GitHub? I'm not seeing it. I can kill this PR and use your branch instead. |
Sorry for confusion... I created a new FB for MY change last week, not this one. I don't think Windows was involved in your PR... you can see the line endings changes via the GitHub Web UI. I'm wondering if IntelliJ is changing line endings in certain cases. |
|
Fresh PR where GitHub didn't mangle the line endings. Not sure why it behaved differently here. #7038 |
Rationale
Recent work on the search queue introduced a no-op implementation for the service. Thus, we don't need to check if it's null anymore.
Changes
SearchServiceand let it do nothing if it choosesTasks 📍