Issue 52614: AssertionError deleting site group from its details page#6469
Merged
labkey-jeckels merged 3 commits intodevelopfrom Mar 25, 2025
Merged
Issue 52614: AssertionError deleting site group from its details page#6469labkey-jeckels merged 3 commits intodevelopfrom
labkey-jeckels merged 3 commits intodevelopfrom
Conversation
This was referenced Mar 24, 2025
Merged
Issue 52614: AssertionError deleting site group from its details page
LabKey/DiscvrLabKeyModules#343
Merged
Merged
Merged
Merged
Merged
labkey-adam
approved these changes
Mar 24, 2025
| { | ||
| _eventType = eventType; | ||
| _container = container; | ||
| _container = container.getId(); |
Contributor
There was a problem hiding this comment.
Should we take this a step further and keep _container and _project as Container? Looks like LogManager and AuditLogImpl turn these IDs back into Container objects.
Contributor
Author
There was a problem hiding this comment.
Sure. I thought about this but didn't go all of the way initially. I pushed edits to make the switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We were sometimes failing to properly do audit logging for group events.
Changes