Complete migration from srcURL and returnURL to returnUrl#6407
Merged
labkey-jeckels merged 2 commits intodevelopfrom Mar 5, 2025
Merged
Complete migration from srcURL and returnURL to returnUrl#6407labkey-jeckels merged 2 commits intodevelopfrom
labkey-jeckels merged 2 commits intodevelopfrom
Conversation
This was referenced Mar 4, 2025
labkey-adam
reviewed
Mar 4, 2025
labkey-adam
approved these changes
Mar 4, 2025
|
|
||
| // when we convert code to use ReturnUrlForm we may leave behind bookmarks using "returnURL" | ||
| @Deprecated | ||
| public ReturnURLString getReturnURL() |
Contributor
There was a problem hiding this comment.
Can we delete this and the setter?
| <h3>OLAP Cube definitions in this folder:</h3> | ||
| <p> | ||
| <%=link("create new", new ActionURL(OlapController.CreateDefinitionAction.class, getContainer()).addReturnURL(getActionURL().clone())).id("create-cube-definition")%> | ||
| <%=link("create new", new ActionURL(OlapController.CreateDefinitionAction.class, getContainer()).addReturnUrl(getActionURL().clone())).id("create-cube-definition")%> |
Contributor
There was a problem hiding this comment.
Do all these methods really need to clone() the getActionURL()?
Contributor
Author
There was a problem hiding this comment.
Nope. Removed
| } | ||
| %> | ||
| <%=link("create new", new ActionURL(OlapController.CreateDefinitionAction.class, getContainer()).addReturnURL(getActionURL().clone()))%> | ||
| <%=link("create new", new ActionURL(OlapController.CreateDefinitionAction.class, getContainer()).addReturnUrl(getActionURL().clone()))%> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In 2021 we made a major push to use
returnUrlconsistently instead ofsrcURLorreturnURL. We can finish the job.Issue 7580: inconsistent use of returnUrl parameter
Changes
returnUrland get rid of code checking for old versions of the parameters