Switch requests to path first URLs

[labkey-klum]

Rationale

• Convert from controller first to path first LabKey URLs
• Introduce labkey.buildURL to handle URL generation. This includes moving the folderPath validation into this method and out of the calling function. Leverage the httr library to generate the URL including any query parameters and URL encoding.
• Refactor selectRows to consolidate parameter generation for both GET and POST methods
• Update makeFilter to support generating filter lists using named elements. This is the format that the httr utilities can accept for URL params more readily. While we aren't making use of this variant in this update, the plan is to eventually migrate to this format by default in a future release of Rlabkey. Until then, we support both the legacy and newer formats for functions that consume the return value of makeFilter.

Related Pull Requests

LabKey/testAutomation#2857

[cnathe]

approving. I'm planning to pull down the changes now to do manual testing. I'll focus mainly on the selectRows colFilters as most of the other changes for the path first part and labkey.buildURL seem like they should be covered by the existing tests.

[cnathe]

we are also checking for missing baseUrl and folderPath in labkey.buildURL. however, here we also check for is.null on baseUrl. should that check also be happening in labkey.buildURL for the various params?

[cnathe]

we don't have to do this URLencode check anymore with the labkey.buildURL? excellent!

[cnathe]

build_url is the part that handles the encoding part now right?

[cnathe]

Manual testing Issue with special character: @labkey-klum
I have a sample type with several columns that have special characters in their names (ex. "aa{aa}", "b b", "d/d", "f,./"). When I try to do a labkey.selectRows call for this sample type with the updated Rlabkey pacakge, I get errors for both the colSelect and the colFilter.

For colSelect="Name,aa{aa},b b,c,c,d/d,e\\e", I get the following error:

_> Error in makeDF(mydata, colSelect, showHidden, colNameOpt) :

The column "c" specified in the colSelect variable does not exist in the result set. Be sure you are using the column name for colNameOpt="fieldname" and the column label for colNameOpt="caption". See the documentation for more details._

I believe this is mainly from the column with name "c,c".

For colFilter=makeFilter(c("e\\e", "IN", "5;e"),c("f$Pf\" testing %22 also", "NOT_MISSING", "")), I get the following error:

_> Error in parseToList(colFilter, dataRegionName = "", urlDecode = TRUE) :

Argument parameters is incorrectly formatted, it needs to be a list of string value pairs delimited by '='_