Skip to content

General platform-logic refactoring & Haiku support.#1827

Merged
tresf merged 7 commits into
LMMS:masterfrom
waddlesplash:master
Mar 7, 2015
Merged

General platform-logic refactoring & Haiku support.#1827
tresf merged 7 commits into
LMMS:masterfrom
waddlesplash:master

Conversation

@waddlesplash
Copy link
Copy Markdown
Contributor

Fixes #1820.

@tresf
Copy link
Copy Markdown
Member

tresf commented Mar 5, 2015

This looks pretty good, but something has broken our win32 builds per:
https://travis-ci.org/LMMS/lmms/jobs/53227720#L1252

-Tres

@waddlesplash
Copy link
Copy Markdown
Contributor Author

There, that should fix shared memory on Windows.

@tresf
Copy link
Copy Markdown
Member

tresf commented Mar 5, 2015

👍

Since this adds a new LMMS_BUILD_HAIKU, I'd like @lukas-w's input before merging. Tremendous. Thanks!

@diizy
Copy link
Copy Markdown
Contributor

diizy commented Mar 6, 2015

In lb302, it'd be better to just remove that MIN macro completely and replace it with qMin() to be consistent with rest of our codebase.

@waddlesplash
Copy link
Copy Markdown
Contributor Author

Done.

Comment thread include/lmms_math.h
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in #1822, I think this #if condition can just be removed and its body enabled on all platforms.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except some OSes may not have these as #defines, so you'll be overriding the OS version.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very valid argument.

@tresf
Copy link
Copy Markdown
Member

tresf commented Mar 7, 2015

@waddlesplash thanks as this cleans things up quite a bit. We'll tag this commit if we have any fallout from a VST perspective. Merging.

tresf added a commit that referenced this pull request Mar 7, 2015
General platform-logic refactoring & Haiku support.
@tresf tresf merged commit 07e422c into LMMS:master Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants