Fix nested directories being created when restarting#10
Merged
PatrickRMiles merged 4 commits intoFeb 17, 2026
Merged
Conversation
added 4 commits
January 29, 2026 13:20
…n; also simplify restart script to more closely match default run method like ScaFFold/scripts/scaffold-tuolumne.job
michaelmckinsey1
requested changes
Jan 29, 2026
michaelmckinsey1
left a comment
Collaborator
There was a problem hiding this comment.
Is this tested?
Collaborator
Author
Yup! |
michaelmckinsey1
self-requested a review
February 6, 2026 02:44
michaelmckinsey1
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torchrun-hpcby default creates a new run directory, which is not what we want when restarting an existing run. This PR solves this by using the-lflag with torchrun-hpc and giving it the absolute path to the existing dir.Also cleans up the restart scripts to more closely match the
scaffold-tuolumne.jobscript we ship with the repo.