Updates to semi-analytical light simulation: optical path tool

[pgreen135]

PR to make semi-analytical model constructor call compatible with new optical path tool.

Corresponds with: LArSoft/larsim#157

[FNALbuild]

A new Pull Request was created by @pgreen135 (Patrick Green) for develop.

It involves the following packages:

larwirecell

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larwirecell/qlmatch/QLMatching.cxx

Then commit the changes and push them to your PR branch.

[FNALbuild]

Pull request #58 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[lynnt20]

Changes look good to me!

[FNALbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larsim#157,SBNSoftware/sbndcode#756,DUNE/dunesw#186,DUNE/duneopdet#104

[lgarren]

@brettviren @HaiwangYu This PR is needed to match changes in LArSoft/larsim#157. Please review and comment or approve.

[FNALbuild]

-LArSoft tests failed on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/27053&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/27052&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12581&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27052&builds=

[FNALbuild]

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/17835&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27052&builds=

[FNALbuild]

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/19860&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27052&builds=

[FNALbuild]

-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/12660&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27052&builds=

[brettviren]

It looks fine to me code-wise but I'm not following this development closely. @HaiwangYu's input is worth more than mine here.

[FNALbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larsim#157,SBNSoftware/sbndcode#756,DUNE/dunesw#193,DUNE/duneopdet#110

[FNALbuild]

-LArSoft tests failed on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/27090&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/27089&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/19880&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27089&builds=

[FNALbuild]

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/17868&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27089&builds=

[FNALbuild]

-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/12692&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27089&builds=

[FNALbuild]

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12601&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/27089&builds=

[lgarren]

approve

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.