Fixing usage across libraries / translation units#189
Closed
philbucher wants to merge 35 commits into
Closed
Conversation
Member
Author
|
Aaaaaaand it is not working in Win 🤦♂️ |
Member
Author
|
ok back to square one, it is not working at all 🙈 Maybe this is the end of header only :/ |
0f2c148 to
48cf7eb
Compare
39 tasks
Member
Author
|
closing as should be fixed since CoSimIO is no longer header only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a few tests that cover different scenarios
The solution I propose seems to work for all of them :)
Now I think we could leave it as header only and still have it working properly!
EDIT: Note that this solution also works without any
extern!closes #184
for reference: https://stackoverflow.com/questions/23690416/c-template-singleton-static-pointer-initialization-in-header-file