adding connection_status#14
Merged
Merged
Conversation
| return ReturnInfo(); // TODO use this, should put a return code based on the bool that comes back from mpComm->Connect() | ||
| const bool is_connected = mpComm->Connect(); | ||
| ReturnInfo ret_info; | ||
| ret_info.Set<bool>("connection_status", is_connected); |
Member
There was a problem hiding this comment.
I thought that you had an int with different options.
Member
There was a problem hiding this comment.
I would also add some constexpr status values like:
- NotConnected: Connect is not called yet
- Connected: after successful call to Connect
- Disconnected: after successful call to Disconnect
- ConnectionError : Having a error message in return_info
- DisconnectionError: Having an error message in return_info
Member
Author
There was a problem hiding this comment.
How would this work for C?
Member
There was a problem hiding this comment.
enums, or const int values
Member
Author
There was a problem hiding this comment.
Wouldn't it then make more sense to use enums also in C++?
Member
There was a problem hiding this comment.
As you like, there is an implicit conversion from enum to int in both languages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now the
connection_statusshould be working as you describe in the tutorial