Skip to content

ci: run release checksums under bash - #127

Merged
KooshaPari merged 2 commits into
mainfrom
fix/windows-checksum-shell
Aug 2, 2026
Merged

ci: run release checksums under bash#127
KooshaPari merged 2 commits into
mainfrom
fix/windows-checksum-shell

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 2, 2026

Copy link
Copy Markdown
Owner

User description

Summary

  • run the POSIX SHA-256 checksum command under bash on every release matrix runner
  • keep Windows x64/ARM release jobs compatible with checksum sidecar uploads
  • assert the generated release workflow records the explicit shell and keep CI/release YAML source-synchronized

This follows post-merge run 30771049704, where both Windows targets failed because the checksum step was interpreted by PowerShell.

Validation

  • env -u CI CARGO_NET_OFFLINE=true CARGO_TARGET_DIR=/private/tmp/forgecode-release-checksum-windows-fix-target cargo test -p forge_ci --test ci (7/7)
  • CI=1 CARGO_NET_OFFLINE=true CARGO_TARGET_DIR=/private/tmp/forgecode-release-checksum-windows-fix-target cargo test -p forge_ci --test ci (7/7)
  • cargo check -p forge_ci --offline
  • cargo fmt --all -- --check
  • git diff --check

CodeAnt-AI Description

Run release checksum generation reliably on Windows

What Changed

  • Release checksum commands now run with Bash on all build runners
  • Windows x64 and ARM release jobs can generate SHA-256 files and upload them with the binaries
  • Generated release workflows verify that checksum steps use Bash

Impact

✅ Fewer Windows release failures
✅ Reliable checksum sidecar uploads
✅ Consistent release artifacts across platforms

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Use the cross-platform bash shell for the POSIX checksum command so Windows release matrix jobs can generate and upload sidecars.\n\nCo-Authored-By: ForgeCode <noreply@forgecode.dev>
Copilot AI review requested due to automatic review settings August 2, 2026 23:30
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codeant-ai

codeant-ai Bot commented Aug 2, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 8881c3f Aug 02, 2026 · 23:30 23:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@socket-security

socket-security Bot commented Aug 2, 2026

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

@codeant-ai codeant-ai Bot added the size:XS label Aug 2, 2026
@mergify mergify Bot added the rust label Aug 2, 2026
Assert the generated matrix keeps both Unix and Windows targets while using the explicit bash checksum shell.\n\nCo-Authored-By: ForgeCode <noreply@forgecode.dev>
@kilo-code-bot

kilo-code-bot Bot commented Aug 2, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .github/workflows/ci.yml - No issues
  • .github/workflows/release.yml - No issues
  • crates/forge_ci/src/jobs/release_build_job.rs - No issues
  • crates/forge_ci/tests/ci.rs - No issues

Reviewed by step-3.7-flash · Input: 59K · Output: 10.1K · Cached: 324.1K

@KooshaPari
KooshaPari merged commit 9af552c into main Aug 2, 2026
26 checks passed
@KooshaPari
KooshaPari deleted the fix/windows-checksum-shell branch August 2, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants