ci: disable unsupported fork package channels - #125
Conversation
Remove upstream npm and Homebrew publication jobs from the generated fork release workflow while retaining binary and checksum uploads.\n\nCo-Authored-By: ForgeCode <noreply@forgecode.dev>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Dependency limit exceeded — report not shown. This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report. Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard. Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account. |
| ) | ||
| .add_step( | ||
| Step::new("Generate SHA-256 checksum") | ||
| .run(r#"if command -v sha256sum >/dev/null 2>&1; then sha256sum "${{ matrix.binary_name }}" > "${{ matrix.binary_name }}.sha256"; else shasum -a 256 "${{ matrix.binary_name }}" > "${{ matrix.binary_name }}.sha256"; fi"#), |
There was a problem hiding this comment.
Suggestion: GitHub Actions uses PowerShell as the default shell on windows-latest, but this step contains POSIX shell syntax (command -v, then, else, and redirection). The Windows matrix jobs will fail during checksum generation, preventing their binaries and checksums from being uploaded. Specify a POSIX shell explicitly or use equivalent PowerShell commands for Windows. [possible bug]
Severity Level: Major ⚠️
- ❌ Windows release matrix jobs fail during checksum generation.
- ❌ Windows binaries and checksum sidecars are not uploaded.
- ⚠️ Every published release loses its Windows artifacts.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/forge_ci/src/jobs/release_build_job.rs
**Line:** 95:95
**Comment:**
*Possible Bug: GitHub Actions uses PowerShell as the default shell on `windows-latest`, but this step contains POSIX shell syntax (`command -v`, `then`, `else`, and redirection). The Windows matrix jobs will fail during checksum generation, preventing their binaries and checksums from being uploaded. Specify a POSIX shell explicitly or use equivalent PowerShell commands for Windows.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fixThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 188889babd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ) | ||
| .add_step( | ||
| Step::new("Generate SHA-256 checksum") | ||
| .run(r#"if command -v sha256sum >/dev/null 2>&1; then sha256sum "${{ matrix.binary_name }}" > "${{ matrix.binary_name }}.sha256"; else shasum -a 256 "${{ matrix.binary_name }}" > "${{ matrix.binary_name }}.sha256"; fi"#), |
There was a problem hiding this comment.
In the generated release workflow this step runs for every matrix entry, including the two windows-latest targets, but GitHub Actions documents that Windows run steps without an explicit shell use pwsh (shell table). This POSIX if ... then ... fi script will fail to parse on those Windows rows before the upload steps run, so the Windows release binaries and checksum assets are not published and the build_release matrix fails; set shell: bash, gate this command to non-Windows, or emit a PowerShell equivalent for Windows.
Useful? React with 👍 / 👎.
Keep the checked-in CI workflow synchronized with ReleaseBuilderJob so generator tests remain authoritative.\n\nCo-Authored-By: ForgeCode <noreply@forgecode.dev>
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
User description
Summary
antinomyhqrepositoriesThe release attestation workflow is unchanged and remains triggered by
release.published.Validation
CI=1 CARGO_NET_OFFLINE=true CARGO_TARGET_DIR=/private/tmp/forgecode-release-channel-fix-target-ci cargo test -p forge_ci --test ci test_release_workflow -- --exactcargo check -p forge_ci --offlinegit diff --checkCodeAnt-AI Description
Make fork releases self-contained with downloadable SHA-256 checksums
What Changed
Impact
✅ Prevents fork releases from publishing to upstream package channels✅ Adds verifiable checksums for every release binary✅ Keeps fork release artifacts available from GitHub Releases💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.