Bound automatic continuation after interrupt limits - #122
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
e01a7c5 to
9ef80b4
Compare
|
Rebased onto current main (07763de) with --force-with-lease; delivery head is now 9ef80b4. Preserved pre-rebase green head as audit/auto-continue-bounded-20260802-pre-rebase (e01a7c5). Before rebasing, all required checks were green, including full test, coverage/build, performance, rustfmt, Clippy, CodeQL, Cargo Deny, Trunk, Semgrep, and Trufflehog. The rebased head has local focused evidence: forge_config schema test (1 passed) and forge_main automatic continuation boundary test (1 passed). New CI is running for the current merge base. PR remains draft pending review. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ef80b479b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }; | ||
| } | ||
|
|
||
| if self.config.auto_continue_on_interrupt || Self::is_non_interactive() { |
There was a problem hiding this comment.
Honor auto-continue opt-in in headless runs
When Forge is run with piped input or in CI, this condition auto-continues after max-request or tool-failure interrupts even when auto_continue_on_interrupt is left at its documented/default false. That makes the per-turn limits stop being a hard cost/runaway guard for non-interactive jobs; a headless invocation that hits max_requests_per_turn now silently starts up to eight more turns instead of stopping unless the user explicitly opted in.
Useful? React with 👍 / 👎.
|
Thanks for the careful review. This behavior is intentional and this change is strictly a safety improvement over the pre-existing path. Before this PR, a headless run that hit a per-turn limit fell through to This PR preserves that headless continuation capability (agent-mode workflows depend on it) but caps the chain at In short: a headless job that hits |
Summary
auto_continue_on_interruptconfiguration and generated schema documentationVerification
mainat07763de7fThe prior green pre-rebase head is preserved as
audit/auto-continue-bounded-20260802-pre-rebase. This branch is ready for owner review; no merge is being performed automatically.