Skip to content

Update to the new project system#122

Merged
Knagis merged 2 commits intoKnagis:masterfrom
sharwell:use-cps
Dec 3, 2018
Merged

Update to the new project system#122
Knagis merged 2 commits intoKnagis:masterfrom
sharwell:use-cps

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Dec 3, 2018

  • Migrate to the new project system, with no functional changes to the build outputs
  • Include a proper .NET Standard 1.0 binary

@Knagis
Copy link
Owner

Knagis commented Dec 3, 2018

Thank you for this! Could I add you as a collaborator on the project so my lack of time wouldn't be an obstacle for merging it when it is ready?

@sharwell
Copy link
Contributor Author

sharwell commented Dec 3, 2018

This seems to be a good start. Additional work can be done in follow-up changes:

  • The manual .nuspec could be changed to a "create package on build"
  • The .nuspec could be moved to CommonMark.Console if we want to create the package on build without worrying about the circular dependency
  • The .nupkg could be attached to the build output
  • The tests could be integrated with OpenCover/codecov.io for code coverage
  • Nerdbank.GitVersioning could be integrated for automatic package versioning support

I wasn't sure which of these (if any) you would be interested in, so I'm pointing them out but not implementing them unless requested. 😄

@Knagis Knagis merged commit 3ab6585 into Knagis:master Dec 3, 2018
@sharwell sharwell deleted the use-cps branch December 3, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants