Fixes to make KWIVER compatible with pybind11 version 2.10.1#1715
Merged
Conversation
Collaborator
Collaborator
Collaborator
Collaborator
Member
Author
Actually this is not dependent on the fletch PR as our current version of pybind11 has the needed changes. This will clear the way for the afore mentioned fletch PR. |
Purg
reviewed
Feb 1, 2023
7403f03 to
d29e2dc
Compare
Collaborator
Collaborator
Collaborator
Collaborator
Purg
approved these changes
Feb 3, 2023
Member
|
Rereading the contributing file, we need a release note here: |
Collaborator
Collaborator
c150f18 to
59a70bb
Compare
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
59a70bb to
3ca3474
Compare
Collaborator
Collaborator
Collaborator
Member
Author
|
jenkins test this please |
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow KWIVER to built against pybind 11 version 2.10.1. This PR is dependent on Kitware/fletch#722.