Adding bulk edit of group #3366

jjomier · 2026-01-13T23:39:09Z

This new feature allows to select multiple builds in a group and move them as a batch or mark the builds expected.

Added fix when image for project is not set
Modified icons for better look and feel

williamjallen

Thanks for this contribution. I left a few initial comments inline. Please also add before and after screenshots to the PR description for all UI changes.

app/Http/Controllers/BuildController.php

app/Models/Build.php

app/Models/BuildGroup.php

resources/views/components/header.blade.php

jjomier · 2026-01-15T00:45:35Z

Thanks @williamjallen I cleaned up the contribution and added a screenshot.

williamjallen · 2026-01-15T14:00:04Z

@jjomier Please see the failing CI. Please also add a test for the new functionality you've added. tests/cypress/e2e/expected-build.cy.js is probably the most relevant place to put new test cases.

williamjallen · 2026-01-18T18:39:44Z

@jjomier There's nothing wrong with debugging via the CI, but it may be more efficient to iterate locally. The instructions for running the test suite in Docker are here. Nothing other than Docker needs to be installed locally to run the tests.

jjomier · 2026-01-18T18:59:17Z

Tests are very unstable on my side when running locally (works one time and fails the second time).
Is there any documentation to run the tests locally from a development branch - I'm probably missing something?

Forgot to mention I'm running in Docker.

williamjallen · 2026-01-18T19:04:23Z

@jjomier Which tests are failing for you locally? I run the tests every day in Docker and haven't noticed any flakiness recently, but it's possible that differences in our machines are revealing a flaky test somewhere. Some of the Cypress tests are flaky in CI. Feel free to open issues for any unstable tests and I can dig a little deeper.

For development, you can use the cdash_copy_source alias in the container to copy files from the host for most iterations. If you're building the frontend, you'll need to run npm run dev afterwards. The cdash_install --dev command is an all-in-one which copies data and runs through all of the installation scripts, but takes a little bit longer.

jjomier · 2026-01-18T19:05:43Z

Thanks for the input! Maybe we can document these commands for other contributors.

jjomier · 2026-01-19T00:10:52Z

Thanks for the patience and help @williamjallen - seems like unit tests are passing now. Feel free to review and modify as needed. This feature will help quite a bit when moving batch builds to new build group.

williamjallen

A few UI comments:

Let's remove the blue color from the info icon so it doesn't stick out as much.
Let's reverse the order of these buttons so logging in simply adds a button rather than changing the layout of both:
Clicking this button briefly shows the "Mark as Not Done" button until the animation finishes. The same applies to the "Mark as Expected" button.
Clicking this button leads to a painfully slow animation as the modal appears:
It looks like the inner table now has new column highlighting. Let's remove that.

tests/cypress/e2e/expected-build.cy.js

jjomier · 2026-01-20T00:03:29Z

@williamjallen what is the best way to reinitialize the testing database. Seems like tests are failing locally and not sure how to reset the database to a proper state.

williamjallen · 2026-01-20T00:08:20Z

@jjomier The install_1 test drops and recreates the database, so there shouldn't be anything else necessary. Depending on which test is failing and how it failed, you may also need to delete the contents of /cdash/storage/app/**/*. You can also check the log file to make sure it's identical to .env.dev.

jjomier · 2026-01-20T15:34:54Z

I would need some help fixing this test as I cannot get the tests to run correctly: now getting over 20 tests failing - wondering if switching to master branch caused any isses.

Is there a way to start fresh? (I tried to remove containers without any luck).

williamjallen · 2026-01-20T15:40:57Z

@jjomier If you switched to master, you probably have more migrations locally than you should. You can delete them with rm /cdash/database/migrations/*. To start fresh, you should delete all containers and volumes, and then start everything back up again. I suspect you removed the containers but not the volumes so the database persisted.

jjomier · 2026-01-21T12:29:47Z

@williamjallen thanks for the help. Should be all good. Removing the transition for the modal caused the old test to fail, which was doing a accept then cancel (not sure why). Should be all good now.

williamjallen

One last code comment to resolve and then this should be good to go.

williamjallen · 2026-01-21T13:07:18Z

tests/cypress/e2e/expected-build.cy.js

+      if (rowCount > 1) {
+        cy.get('#project_5_13').find('tbody').find('tr').eq(1).find('[data-cy="build-admin-options"]').click();
+        cy.get('#project_5_13').find('tbody').find('tr').eq(1).find('table.animate-show').should('be.visible');
+        cy.get('[data-cy="mark-as-expected-btn"]').should('exist');
+        cy.get('[data-cy="mark-as-non-expected-btn"]').should('not.exist');
+        // close admin options
+        cy.get('#project_5_13').find('tbody').find('tr').eq(1).find('[data-cy="build-admin-options"]').click();
+      }


Let's remove this conditional so there's only one code path the test can take.

jjomier added 3 commits January 13, 2026 17:44

Fixing error when image is not set for a project

4f4d47d

Added bulk move feature

854c55f

Changed icons for uniform look

34d0c8a

williamjallen self-requested a review January 14, 2026 02:17

williamjallen requested changes Jan 14, 2026

View reviewed changes

app/Http/Controllers/BuildController.php Outdated Show resolved Hide resolved

app/Models/Build.php Outdated Show resolved Hide resolved

app/Models/BuildGroup.php Outdated Show resolved Hide resolved

resources/views/components/header.blade.php Outdated Show resolved Hide resolved

Revert unecessary changes

3cc8241

jjomier added 3 commits January 17, 2026 14:36

Fix test

10ceba2

Fixed test

3c740cb

Fix lint

18a0d90

jjomier added 2 commits January 18, 2026 16:12

Added test for bulk edit

907f5f8

Fixing done-build test

8e7b3d1

williamjallen requested changes Jan 19, 2026

View reviewed changes

tests/cypress/e2e/expected-build.cy.js Outdated Show resolved Hide resolved

tests/cypress/e2e/expected-build.cy.js Outdated Show resolved Hide resolved

tests/cypress/e2e/expected-build.cy.js Outdated Show resolved Hide resolved

williamjallen added the release notes: features label Jan 19, 2026

williamjallen added this to the v4.9 milestone Jan 19, 2026

jjomier added 3 commits January 19, 2026 11:12

Fix tests

5bebf7a

Fixing UI issues

86e7c5f

Fix lint

a756900

Fixing test

3f073fb

williamjallen requested changes Jan 21, 2026

View reviewed changes

Adding bulk edit of group #3366

Are you sure you want to change the base?

Adding bulk edit of group #3366

Conversation

jjomier commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

williamjallen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjomier commented Jan 15, 2026

Uh oh!

williamjallen commented Jan 15, 2026

Uh oh!

williamjallen commented Jan 18, 2026

Uh oh!

jjomier commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

williamjallen commented Jan 18, 2026

Uh oh!

jjomier commented Jan 18, 2026

Uh oh!

jjomier commented Jan 19, 2026

Uh oh!

williamjallen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjomier commented Jan 20, 2026

Uh oh!

williamjallen commented Jan 20, 2026

Uh oh!

jjomier commented Jan 20, 2026

Uh oh!

williamjallen commented Jan 20, 2026

Uh oh!

jjomier commented Jan 21, 2026

Uh oh!

williamjallen left a comment

Choose a reason for hiding this comment

Uh oh!

williamjallen Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jjomier commented Jan 13, 2026 •

edited

Loading

jjomier commented Jan 18, 2026 •

edited

Loading