Skip to content

Treat Assembly Loads as messages #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KirillOsenkov merged 2 commits into from
Feb 9, 2023
Merged

Treat Assembly Loads as messages #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6275b3d
Treat Assembly Loads as messages
JanKrivanek Feb 9, 2023
f31fc93
Intern message
JanKrivanek Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/StructuredLogger/Construction/MessageProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,11 @@ public void AddMessage(LazyFormattedBuildEventArgs args, string message)
parent = GetTask(args);
if (parent is Task task)
{
if (task is ResolveAssemblyReferenceTask rar)
if (args is AssemblyLoadBuildEventArgs)
{
nodeToAdd = new Message() { Text = Intern(message), IsLowRelevance = lowRelevance };
}
else if (task is ResolveAssemblyReferenceTask rar)
{
if (ProcessRAR(rar, ref parent, message))
{
Expand Down