Fix unit test#3
Merged
Merged
Conversation
Author
|
@JuliaSprenger Do you know when you'll have a chance to review? Ideally, I would like to release 2.0 end of the week or the following week and I would like this contribution to be included. |
Owner
|
Sorry, I lost track of this thread. Looks good to me. Thanks for taking over the last fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up reverting c35bbb6. I actually like testing all the different formats in the integration test -- I ended up finding a bug that way 😄
With these unit tests passing it brings code coverage back up to 💯 🎉
great work 👏🏻 👏🏻 👏🏻 (promise I'm not going to add anything else to this PR 😅)