Add doctests and integration tests for repeating forms#2
Merged
Conversation
The current setup requires every new endpoint that could be returned as a data frame to be added here. That's bad form, let's just make the default be an empty dict
Similar to the prior change this was hard coded for record and metadata requests. But as this PR is demonstrating there a lot of other endpoints out there that allow imports and we certainly don't want to have to include each one in here. All that really seems to matter is whether or not there _is_ a named index. If there is, we want to keep it when we export. If there's not, then we don't need it. As you can see from the test, importing from a dataframe will likely still require some finneagling on the part of the user to ensure all the formats are correct.
Author
|
Just wanted to sneak the docs update in there while I was thinking about it. I def need a checklist for things to do when adding a new category of endpoints 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really grateful for your test cases, they revealed some weak points in the existing code. The doctest/long project xml files/test files have been updated and everything works as expected. Once merging this, you'll be ready to add unit tests (if you want 😉 )