Add DelimitedFiles package and compat for it to packages#66039
Merged
Conversation
UUID: 8bb1440f-4735-579b-a4ab-409b98df4dab Repo: https://github.com/JuliaData/DelimitedFiles.jl.git Tree: 19b1417ff479c07e523fcbf2fd735a3fde3d1ab3 Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec (cherry picked from commit 9539634)
Member
Author
|
The PR here should be safe in the sense that the info here should be completely ignored on pre 1.9 Julias and it is also easy to revert since you would just remove all the lines with DelimitedFiles in Compat files. |
DilumAluthge
approved these changes
Aug 10, 2022
DilumAluthge
left a comment
Member
There was a problem hiding this comment.
To be safe, it would be nice to do a PkgEval run using this branch of the registry, just to make sure that we aren't missing anything.
Member
Author
JuliaLang/julia#45540 (comment) ran on a branch that included this PR and didn't show any problems. |
This was referenced Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan is to move out DelimitedFiles from being an stdlib to being an external package. However, there is no compat on standard libraries. When people start using DelimitedFiles as a normal package, the lack of compat will be problematic.
As described in JuliaLang/julia#45540 (comment), this mirrors the compat for Julia to that of DelimitedFiles which should make sense for existing versions, new versions of packages pre 1.9 should have compat on DelimitedFiles that mirrors their Julia compat, packages only supporting 1.9+ are free to have any compat on DelimitedFiles.