Fix test for exponentially growing promote_type#280
Merged
kimikage merged 1 commit intoJuliaMath:masterfrom Apr 6, 2024
Merged
Fix test for exponentially growing promote_type#280kimikage merged 1 commit intoJuliaMath:masterfrom
promote_type#280kimikage merged 1 commit intoJuliaMath:masterfrom
Conversation
This follows the behavior, i.e. the order of evaluation, in `Base`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 6 6
Lines 785 785
=======================================
Hits 762 762
Misses 23 23 ☔ View full report in Codecov by Sentry. |
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 13, 2024
This backports PR JuliaMath#280
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 13, 2024
kimikage
added a commit
that referenced
this pull request
May 13, 2024
* Backport "Fix test for exponentially growing `promote_type` (#280)" * fix tests on 1.7 (#253) Co-authored-by: Johnny Chen <johnnychen94@hotmail.com> Co-authored-by: kimikage <kimikage.ceo@gmail.com> * Mark `test_broken` for conversion to `Float16` * Backport "Add test for `unsafe_trunc` returning arbitrary values (#289)" --------- Co-authored-by: Kristoffer Carlsson <kricarl@student.chalmers.se> Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the behavior, i.e. the order of evaluation, in
Base.It was changed recently in the nightly build (cf. JuliaLang/julia#53665), and it might be changed further in the future.
I thought Julia was getting very smart, but that was not the case. 😆