Change test targets of Fixed#218
Merged
kimikage merged 1 commit intoJuliaMath:masterfrom Aug 19, 2020
Merged
Conversation
89666b6 to
cbabab6
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 88.55% 89.35% +0.80%
==========================================
Files 6 6
Lines 498 498
==========================================
+ Hits 441 445 +4
+ Misses 57 53 -4
Continue to review full report at Codecov.
|
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 27, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the revision of PR #208, I unintentionally dropped the upper limit of the number of fractional bits
fforFixed(e.g.Q0f7-->Q0f6).Of course, the tests should be passed independent of
f, so ideally the selection offs makes no difference. However, in general, the quality of tests is higher when using boundary values. In fact, two edge cases (but not a bug) have been detected.