Skip to content

suggest: minor inference improvements #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timholy merged 1 commit into from
Jan 24, 2021
Merged

suggest: minor inference improvements #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/parcel_snoopi_deep.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ function suggest(itrig::InferenceTrigger)
# It's not clear that the following is useful
tt = Base.unwrap_unionall(itrig.callerframes[end].linfo.specTypes)::DataType
cts = Base.code_typed_by_type(tt; debuginfo=:source)
if length(cts) == 1 && cts[1][1].inlineable
if length(cts) == 1 && (cts[1][1]::CodeInfo).inlineable
push!(s.categories, CallerInlineable)
end
end
Expand All @@ -1288,7 +1288,7 @@ function suggest(itrig::InferenceTrigger)
push!(s.categories, CallerVararg)
end
maybec = false
for (ct, rt) in cts
for (ct::CodeInfo, _) in cts
# Check for Core.Box
for typlist in (ct.slottypes, ct.ssavaluetypes)
for typ in typlist
Expand All @@ -1305,7 +1305,7 @@ function suggest(itrig::InferenceTrigger)
stmt = ct.code[stmtidx]
if isa(stmt, Expr)
if stmt.head === :invoke
mi = stmt.args[1]
mi = stmt.args[1]::MethodInstance
if mi == MethodInstance(itrig.node)
if mi.def.isva
push!(s.categories, InvokedCalleeVararg)
Expand Down