Improve selectivity in "deep" invalidations #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former implementation collected some "spurious" invalidations: methods in `Core` (which runs in an old world-age) and precompiled CodeInstances (which get loaded from cache with max_world = 0). This also returns the full InferenceTimingNodes, which seems useful since it gives a sense of the cost of recompiling it.
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 80.91% 80.79% -0.12%
==========================================
Files 9 9
Lines 1352 1354 +2
==========================================
Hits 1094 1094
- Misses 258 260 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former implementation collected some "spurious" invalidations:
methods in
Core(which runs in an old world-age) and precompiledCodeInstances (which get loaded from cache with max_world = 0).
This also returns the full InferenceTimingNodes, which seems useful
since it gives a sense of the cost of recompiling it.