Fix a rare test failure in snoopi_deep #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the tests relies on the two fastest-to-infer MethodInstances having a difference in their inference times. However, in rare cases they can "tie." Just skip this portion of the tests when this happens.
9566c60 to
59a945a
Compare
timholy
added a commit
that referenced
this pull request
Nov 25, 2020
The fix in #155 was incomplete, this should do it.
timholy
added a commit
that referenced
this pull request
Nov 25, 2020
The fix in #155 was incomplete, this should do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tests relies on the two fastest-to-infer MethodInstances
having a difference in their inference times. However, in rare cases
they can "tie." Just skip this portion of the tests when this happens.