Skip to content

Conversation

@aminya
Copy link
Contributor

@aminya aminya commented Oct 1, 2020

This deprecates SnoopCompileBot in favor of CompileBot.

Because SnoopCopmileBot was in a sub-directory of this repository, changing the URL is not possible due to git limitations. I decided to rename the package.

I would appreciate it if you can merge this and register a new version for SnoopCompileBot. Then, remove the directory when the registration is done.

JuliaRegistries/General#22253
JuliaRegistries/General#19557
JuliaRegistries/General#21615

@timholy
Copy link
Member

timholy commented Oct 1, 2020

Happy to do this, but just to make sure: where precisely is the problem? Are you talking about the registry? (I don't think that should be a problem, but you will have to submit a manual PR to General.) Or github transfer & ownership? Something else?

@aminya
Copy link
Contributor Author

aminya commented Oct 1, 2020

Yes. The issue is in the registration. The general registry stores one URL for the whole package. That means the git-shas specified there rely on that URL. When I made the new package, I started fresh (I did not clone this repository). That means the old git-shas will not be valid anymore.

JuliaRegistries/General#19557
JuliaRegistries/General#21615

The long-term solution that I see is to extend Pkg so it stores the URL for each version instead of having one single URL for the whole thing.

Another thing is that I had an idea to make an automated bot for PackageCompiler. I decided to see this issue as an opportunity for extending SnoopCopmileBot to CompileBot.

@aminya
Copy link
Contributor Author

aminya commented Oct 1, 2020

I forgot to say that we should wait until the new package gets registered: JuliaRegistries/General#22253

@timholy
Copy link
Member

timholy commented Oct 1, 2020

If people only want the latest-and-greatest, I don't see a problem with just changing the URL. But perhaps you're wanting to maintain the availability of older versions too, in which case this makes sense.

As long as you're happy about the name change, then of course it's fine, just wanted to make sure you weren't giving up for the wrong reasons.

@timholy
Copy link
Member

timholy commented Oct 1, 2020

Just ping me when you want me to merge this.

@aminya
Copy link
Contributor Author

aminya commented Oct 17, 2020

@timholy CompileBot is now registered. This should be ready if no error happens.

@timholy timholy merged commit d347178 into JuliaDebug:master Oct 17, 2020
@timholy timholy deleted the deprecate-SnoopCompileBot branch October 17, 2020 07:34
@timholy
Copy link
Member

timholy commented Oct 17, 2020

Not sure if JuliaRegistries/General#23132 should have also included SnoopCompileBot? If necessary, please register a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants