inline sub_axes_map(T::Type{<:SubArray}))#28
Merged
ChrisRackauckas merged 1 commit intoJuliaArrays:masterfrom Apr 19, 2023
ranocha:hr/fix_performance_issue
Merged
inline sub_axes_map(T::Type{<:SubArray}))#28ChrisRackauckas merged 1 commit intoJuliaArrays:masterfrom ranocha:hr/fix_performance_issue
ChrisRackauckas merged 1 commit intoJuliaArrays:masterfrom
ranocha:hr/fix_performance_issue
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 88.72% 88.65% -0.08%
==========================================
Files 11 11
Lines 1313 1313
==========================================
- Hits 1165 1164 -1
- Misses 148 149 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
The downstream CI failure cannot be related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some serious performance issues for us in Trixi.jl increasing the runtime up to two orders of magnitude.
Another option would be to remove the
@nospecializein the method definition I changed here.It is hard to provide a good test for it since it is deeply nested, involves LoopVectorization.jl, and is related to nasty issues such as JuliaLang/julia#35800 and JuliaLang/julia#45388
It would be great if we could merge this and make a new release of StaticArrayInterface.jl.
CC @sloede