Merged
Conversation
Add ability to write out run and event numbers to use for skimming.
This has SVT opening angle and front translation values as derived from run 10022.
Correct the sign of the bottom opening angle.
Introduce shifts to reduce deltaY at hinge.
Fix sign of offset
Update with offsets determined AFTER slopes were corrected.
iter1 has opening angle corrections iter2 has deltay at hinge corrections after running iter1 to get the updated deltas
First set of track quality histograms.
Update track quality histograms
separate track quality histograms by particle id
converted cloud to histogram after determining appropriate binning.
Added support for old survey constants
omar-moreno
approved these changes
Nov 11, 2022
Collaborator
omar-moreno
left a comment
There was a problem hiding this comment.
Just new detectors that don't impact the code. Looks fine.
pbutti
approved these changes
Nov 11, 2022
Contributor
|
There are two things that I would like to do before hitting the button, but they shouldn't block
I will do it tomorrow. |
Added detctor for 2019 - Pass 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add detectors to be used for 1% pass0 of 2019 and 2021 data in the winter of 2022.