Skip to content

Comments

Iss 928#929

Merged
cbravo135 merged 3 commits intomasterfrom
iss-928
Nov 14, 2022
Merged

Iss 928#929
cbravo135 merged 3 commits intomasterfrom
iss-928

Conversation

@andrea-celentano
Copy link
Contributor

@andrea-celentano andrea-celentano commented Nov 7, 2022

No description provided.

@andrea-celentano andrea-celentano linked an issue Nov 7, 2022 that may be closed by this pull request
ECAL position corrections for 2021 #928
Closed
@andrea-celentano andrea-celentano self-assigned this Nov 7, 2022
@andrea-celentano
Copy link
Contributor Author

andrea-celentano commented Nov 7, 2022

This should close the 2021 position corrections - they were still to be finished (my fault!).

@andrea-celentano
Copy link
Contributor Author

andrea-celentano commented Nov 7, 2022 •
edited
Loading

Ok, this is really annoying. I got an error in the compilation regarding some weird "code style":

image

I am using Eclipse for code development, and in the confluence page: https://confluence.slac.stanford.edu/display/hpsg/Project+Development+in+Eclipse#ProjectDevelopmentinEclipse-ProjectSourceCodeFormatting
nothing is reported about - I already implemented the "spaces only" policy.

I am not going to spend any time in fixing this.

@cbravo135
Copy link
Collaborator

cbravo135 commented Nov 14, 2022

Thank you @mholtrop for linting this!

normangraf
normangraf approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes result in an improvement in the track-cluster matching of FEEs of a little over 0.5mm. Looks good, please proceed.

cbravo135
cbravo135 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@cbravo135 cbravo135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded constants updated in 2021 ecal cluster position correction.

@cbravo135 cbravo135 merged commit 2de078b into master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbravo135 cbravo135 cbravo135 approved these changes

@normangraf normangraf normangraf approved these changes

@baltzell baltzell Awaiting requested review from baltzell

@JeremyMcCormick JeremyMcCormick Awaiting requested review from JeremyMcCormick

@afilippi67 afilippi67 Awaiting requested review from afilippi67

@mccaky mccaky Awaiting requested review from mccaky

@mholtrop mholtrop Awaiting requested review from mholtrop

@omar-moreno omar-moreno Awaiting requested review from omar-moreno

Assignees

@andrea-celentano andrea-celentano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ECAL position corrections for 2021

4 participants

@andrea-celentano @cbravo135 @normangraf @mholtrop