Conversation
…ng; add driver to run on randoms runs as well
Collaborator
Author
|
I personally have been using this code for a while now, it doesn't seem to break anything. |
JeremyMcCormick
approved these changes
May 5, 2022
Member
JeremyMcCormick
left a comment
There was a problem hiding this comment.
This appears fine to me. The changes to the monitoring app are minor with just an additional command added. Other changes including addition of drivers and changes to existing ones, as well as new steering files, appear to be almost entirely isolated to the monitoring package and have presumably been tested and run in the counting house. There are a few minor changes to tracking classes which just make some methods publicly accessible. Code formatting looks good, too.
bloodyyugo
approved these changes
May 5, 2022
Contributor
bloodyyugo
left a comment
There was a problem hiding this comment.
This builds and doesn't change anything in the reconstruction path. Thanks for getting this in...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the code by Matt G to get the monitoring code working for use during the 2021 run.