Merged
Conversation
Contributor
Author
|
This PR modifies only files related to alignment and monitoring, with no impact on reconstruction chain.
|
cbravo135
approved these changes
Apr 28, 2022
Collaborator
cbravo135
left a comment
There was a problem hiding this comment.
Thank you PF for making some nice additions to the alignment monitoring.
cbravo135
reviewed
May 5, 2022
|
|
||
| if (track.getTrackStates().get(0).getTanLambda() > 0) { | ||
| //Avoid tracks too close to the beamline to have a more reliable result on z from single volumes | ||
| if (track.getTrackStates().get(0).getTanLambda() > 0.035) { |
Collaborator
There was a problem hiding this comment.
In general, I think these configuration parameters should be put into a steering file and not hard coded. Hard coding selections should be avoided in general.
Contributor
Author
There was a problem hiding this comment.
Yeah. But this code is only for monitoring.
Contributor
Author
|
I have another iteration with the configurable selections. We should develop a trackSelector tool to keep those selections in a single place. At the moment they are copied everywhere multiple times. |
Fixed compilation error due to duplicated setMomC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.