Merged
Conversation
…ected to public so that the method can be used out of package
…ReadoutDriver: reset adcBufferMap to ensure that other overlaid events do not affect the current event once an overlaid event is input into the driver
…and hodo into account
normangraf
approved these changes
Mar 21, 2022
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Looks good.
Please proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The software development is for application of pulser data merging in the readout system.
Update of the Readout System for Beam Background Merging.pdf
With plenty of tests, the new readout system for pulser data merging works well.
Here are results from validation study by comparison of vertex among pure tritrig, tritrig + MC beam, tritrig + pulser data, and physics run of 2019.
recoVertex.pdf