Skip to content

Comments

Iss893: update Hodoscope reconstruction drivers to work for MC#897

Merged
tongtongcao merged 2 commits intomasterfrom
iss893
Feb 12, 2022
Merged

Iss893: update Hodoscope reconstruction drivers to work for MC#897
tongtongcao merged 2 commits intomasterfrom
iss893

Conversation

@tongtongcao
Copy link
Contributor

@tongtongcao tongtongcao commented Feb 8, 2022

Recently, it was found that hodoscope reconstruction drivers not to work for MC.
The drivers are developed to process data, and work well. However, there are several differences between data from Hodo evio reader and samples from MC reaout:

  1. Output collection name is different
  2. Cell ID is different
  3. Detector element is not set for Hodo hits in MC readout, while it is set in Hodo evio reader.

The evio reader and MC readout were developed by different authors at different time. So format of output collections from them is not uniform. The issue has not been found before since we have not taken detailed analysis for MC recon Hodo samples.

With the updates, format of output collection from recon. drivers is uniform for data and MC. For ids of Hodo hits, the same logic is processed for MC as logic in Hodo evio reader. The logic is commented by Rafo in the Hodo evio reader:
// ====================== Rafo =======================
// Unlike to the ECal case, where each detector element is readout with a single channel
// here for the hodoscope, there are detector elements (tiles) that are readout with two different channels
//
// The code below, previously was assigning the hole value to 0,
// That way you would get an iD, which is ok for the detector element identification, howevere
// This id is not correct, when one wants to knwo which PMT channel is actually this hit belongs to.
// In particular during the recon, I was getting an error, that it can not find a cellID

    // Now as a possible solution (Possibly not the best solution), this method will return two IDs
    // The 1st one, is clauclulated taking into account the hit, while the 2nd one is calculated with 
    // the "hole=0" assumption.
    
    // Further depending on the intention, one can use ids.get(0) if one wants to check the hit ID, or ids.get(1), if onw
    // wants to identify the detector element.

Besides drivers, all related steering files for MC recon have been updated.

Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and all tests pass. Please proceed.

@tongtongcao tongtongcao merged commit 0fd1fe9 into master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants