Iss893: update Hodoscope reconstruction drivers to work for MC#897
Merged
tongtongcao merged 2 commits intomasterfrom Feb 12, 2022
Merged
Iss893: update Hodoscope reconstruction drivers to work for MC#897tongtongcao merged 2 commits intomasterfrom
tongtongcao merged 2 commits intomasterfrom
Conversation
normangraf
approved these changes
Feb 8, 2022
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Builds and all tests pass. Please proceed.
bloodyyugo
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, it was found that hodoscope reconstruction drivers not to work for MC.
The drivers are developed to process data, and work well. However, there are several differences between data from Hodo evio reader and samples from MC reaout:
The evio reader and MC readout were developed by different authors at different time. So format of output collections from them is not uniform. The issue has not been found before since we have not taken detailed analysis for MC recon Hodo samples.
With the updates, format of output collection from recon. drivers is uniform for data and MC. For ids of Hodo hits, the same logic is processed for MC as logic in Hodo evio reader. The logic is commented by Rafo in the Hodo evio reader:
// ====================== Rafo =======================
// Unlike to the ECal case, where each detector element is readout with a single channel
// here for the hodoscope, there are detector elements (tiles) that are readout with two different channels
//
// The code below, previously was assigning the hole value to 0,
// That way you would get an iD, which is ok for the detector element identification, howevere
// This id is not correct, when one wants to knwo which PMT channel is actually this hit belongs to.
// In particular during the recon, I was getting an error, that it can not find a cellID
Besides drivers, all related steering files for MC recon have been updated.