Conversation
JeremyMcCormick
approved these changes
Jul 14, 2021
Member
JeremyMcCormick
left a comment
There was a problem hiding this comment.
Steering file only - looks fine.
normangraf
approved these changes
Jul 19, 2021
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Looks good.
Please proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For trigger tuning analysis of the upcoming 2021 experiment, some special setup needs to be taken in readout and recon. steering files.
The steering files out of hps-java have been applied to produce MC samples for 2021 trigger tuning.
To let the files work for scripts of hps-mc, those files need to be added into hps-java.