Iss851: Consolidate online monitoring modules#877
Merged
JeremyMcCormick merged 5 commits intomasterfrom Jun 10, 2021
Merged
Conversation
Contributor
|
This looks like a very useful consolidation of these various modules. I don't feel qualified to rigorously test these changes, so I'll have to defer to @bloodyyugo and the subdetector experts who have run the online monitoring. |
Member
Author
|
The project builds successfully and the monitoring app starts fine.
Unlikely this broke anything since all the packages are the same, and
running from the generated assembly scripts or bin jar would not be
affected - that is all managed through distribution, which was not changed
aside from modifying the required deps to use the new module instead of the
old ones.
But more detailed verification can be done if necessary. Any bugs
introduced would anyways likely be quite minor.
…On Wed, Jun 9, 2021 at 8:23 PM normangraf ***@***.***> wrote:
This looks like a very useful consolidation of these various modules. I
don't feel qualified to rigorously test these changes, so I'll have to
defer to @bloodyyugo <https://github.com/bloodyyugo> and the subdetector
experts who have run the online monitoring.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#877 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQXV42C6QROW4D3ADSNDP3TSAHZZANCNFSM46NCNSSA>
.
|
normangraf
approved these changes
Jun 10, 2021
Contributor
normangraf
left a comment
There was a problem hiding this comment.
Consolidating these into one module should make things much easier to maintain.
All the tests run to completion.
Looks good.
Please proceed.
bloodyyugo
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following modules were moved into the new online-monitoring module:
This was done to reduce the overall build time, cut down on clutter at the top-level of the project, simplify dependencies, and put all code and resources under the org.hps.monitoring package in a single place. All files were moved using git so that their histories were left intact.
The online-recon module is kept as is because it has significantly different dependencies.